> On May 2, 2013, 7:16 a.m., Martin Klapetek wrote: > > It's a crazy hack...that works. Given the situation with TpQt, I'm ok > > shipping this for now (also with stable). I'd prefer to not spread this > > further (like putting in the lib) as it should be fixed properly upstream, > > at which point this should be removed. > > > > Ideally wait for other comments.
OK, will commit on Saturday night unless there are any comments in the mean time. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110265/#review31866 ----------------------------------------------------------- On May 1, 2013, 10:26 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110265/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 10:26 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Work around https://bugs.freedesktop.org/show_bug.cgi?id=57739. > > Due to a bug in TelepathyQt if we request a feature that the connection does > not support, it simply fails. > > Local-XMPP does not support grouping, so salut the local-xmpp spec does not > either. > When we request the ContactRosterGroups feature on all connections, salut > fails and therefore doesn't show any contacts. > > Fetching ContactRosterGroups seperately is not a viable option as contacts > would move after loading > > In this hack we make a new ConnectionFactory that fetches ContactRosterGroups > on all connections _except_ salut > > > Diffs > ----- > > main-widget.cpp 92ff083365636dae1fc28fe56b58e7c08cfb225f > > Diff: http://git.reviewboard.kde.org/r/110265/diff/ > > > Testing > ------- > > Opened my contact list.. saw me on my laptop \o/ > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
