> On May 4, 2013, 10:37 a.m., David Edmundson wrote: > > and ship it! :D > > > > Martin Klapetek wrote: > Also whenever you're doing UI changes, be sure to include screenshots too > ;)
Yes, I considered it, but since it was very very minor changes (3 pixel padding etc) I didn't, especially since they were discussed on the other review already ;) But I'll attach a screenshot again next time. - Sven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110291/#review31999 ----------------------------------------------------------- On May 4, 2013, 12:05 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110291/ > ----------------------------------------------------------- > > (Updated May 4, 2013, 12:05 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This is the second set of changes for the kded settings module. The changes > are effectively very minor, but since I'm new to the code base I'd like to > have them reviewed neverthereless. ;) > > * Add a 3 pixel spacing at the top and the bottom of the icons list, as > suggested on the other review request > * Disable the labels, too, not just the input widgets (makes them look greyed > out); for this I rearranged the code a bit otherwise it'd get ugly > * Folder -> folder (this got lost in the diff, sorry) > > Probably not much discussion is needed here. ;) > > > Diffs > ----- > > config/nowplaying-listwidget.cpp 13aab1a > config/telepathy-kded-config.h b1bf626 > config/telepathy-kded-config.cpp 5a7e91d > config/telepathy-kded-config.ui 74ce51e > > Diff: http://git.reviewboard.kde.org/r/110291/diff/ > > > Testing > ------- > > > Thanks, > > Sven Brauch > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
