----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111091/#review34755 -----------------------------------------------------------
Sorry I still have a couple of issues: 1) Instead of reading and saving the lastDownloadDirectory entry you can use the kfiledialog:///XXXXXXX syntax for file dialog (see ktp-contact-list/contact-list-widget.cpp:371). You can also use the static methods for KFileDialog, so that you don't need to add a pointer to the class. 2) I don't like at all that if you enable the "Always Ask" flag you get first a dialog to choose the directory and then, if the file exists, a second dialog to rename the file. Imho, if you enable the flag you should get just one file chooser dialog, with a warning if you are overwriting an existing file, and you should skip the checkFileExists() call and go straight to checkPartFile(); - Daniele E. Domenichelli On June 20, 2013, 9:34 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111091/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 9:34 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Implements support for "Always Ask" for filetransfer destination directory > option. > > The hack with __k__onDownloadDirectoryCancelled() is necessary because > KDirSelectDialog::result() always returns 0 and buttonClicked() signal is > emitted even when "New Folder" button is clicked and handling that would make > the code more complicated. > > > This addresses bug 295937. > http://bugs.kde.org/show_bug.cgi?id=295937 > > > Diffs > ----- > > src/CMakeLists.txt ebd892c > src/filetransfer-handler.cpp 74c701e > src/handle-incoming-file-transfer-channel-job.h d5e53c4 > src/handle-incoming-file-transfer-channel-job.cpp 7a15237 > > Diff: http://git.reviewboard.kde.org/r/111091/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
