----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111256/#review35124 -----------------------------------------------------------
KTp/Models/kpeopletranslationproxy.cpp <http://git.reviewboard.kde.org/r/111256/#comment25690> why adding commented qDebug? Yes, I think that it belongs to ktp-common-internals :) - Aleix Pol Gonzalez On June 26, 2013, 2:19 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111256/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 2:19 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Import the KPeople KTP integration plugins > > There are two plugins, one for the datasource which provides > IM data in real time. > > The other is an actions plugin which provides actions that can be started on > a PersonsData. > > We need to provide KTp integration into libkpeople in a plugin, but we also > want to access this > singleton of accounts/contacts from the other plugin and from the KTp Models. > To do this a static library > ktpkpeople is created and everything links against that. > > KTp Models the actions plugin and the im data source all link against this. > > > Diffs > ----- > > kpeople/actionsplugin/implugin.h PRE-CREATION > kpeople/actionsplugin/CMakeLists.txt PRE-CREATION > KTp/Models/kpeopletranslationproxy.cpp PRE-CREATION > KTp/Models/CMakeLists.txt 720a5b02465b825b08d12d7c43342ad1ba69c9d1 > CMakeLists.txt a83069d59fed945d04560662e3a307ef33b28332 > kpeople/actionsplugin/implugin.cpp PRE-CREATION > kpeople/actionsplugin/ktp_kpeople_plugin.desktop PRE-CREATION > kpeople/common/CMakeLists.txt PRE-CREATION > kpeople/common/impersonsdatasource.h PRE-CREATION > kpeople/common/impersonsdatasource.cpp PRE-CREATION > kpeople/datasourceplugin/CMakeLists.txt PRE-CREATION > kpeople/datasourceplugin/im_persons_data_source_plugin.desktop PRE-CREATION > kpeople/datasourceplugin/impersonsdatasourceplugin.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111256/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
