> On July 8, 2013, 8:13 p.m., Martin Klapetek wrote: > > I thought I'd shipped it before, sorry :P > > David Edmundson wrote: > Should I put this in 0.6 (and the deactivate FeatureRoster in > text-ui/contact-applet factories)? > > it should make loading faster, and prevent a bug that I heard about on > IRC where some guy had 10 contact-applets and they were all trying to update > his avatar cache of every contact. On the other hand it's quite a large > change. Also it means if you ran 0.6.3 of text-ui with 0.6.2 of > ktp-common-internals it wouldn't work.
I've made an executive decision. I'll push to master, if it all works OK I may backport. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111440/#review35766 ----------------------------------------------------------- On July 8, 2013, 8:12 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111440/ > ----------------------------------------------------------- > > (Updated July 8, 2013, 8:12 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Upgrade the Tp::Connection to include FeatureRoster inside > GlobalContactManager > > GlobalContactManager is useless without FeatureRoster so it makes sense > that if one instantiates this class, we upgrade the connection. > > This will allow apps that only occasionally need a full contact list > such as contact-applet and text-ui to not rely on FeatureRoster in the > factory and thus > can a connection object without loading details on every contact ever. > > This is an important step towards a singleton AccountManager (I now have a > plan), in addition > text-ui will load substantially faster. > > > Diffs > ----- > > KTp/global-contact-manager.h 1c903c12775c096d93fef1ec0e313ff2b2824262 > KTp/global-contact-manager.cpp c293e005f1ab0436dcd5c77ddc6607dba1f18896 > KTp/types.h 652a7eadce080ff60cbfd1334c00476fe4bb4cd3 > > Diff: http://git.reviewboard.kde.org/r/111440/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
