----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111511/#review35963 -----------------------------------------------------------
Ship it! Seems fine. KTp/Widgets/join-chat-room-dialog.cpp <http://git.reviewboard.kde.org/r/111511/#comment26623> This has the potential to fail if you were to add an account after running this dialog..probably not too important. (adding to the AccountFactory is often easier) KTp/Widgets/join-chat-room-dialog.cpp <http://git.reviewboard.kde.org/r/111511/#comment26624> If one account doesn't support FeatureCapabilities (not sure I know of any, but legitimately this can happen I guess) this won't be continued. There's a Tp::CompositeJob which is perfect for this sort of things. - David Edmundson On July 14, 2013, 11:07 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111511/ > ----------------------------------------------------------- > > (Updated July 14, 2013, 11:07 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > As the title says. This makes it much easier to use the dialog. > > > Diffs > ----- > > KTp/Widgets/join-chat-room-dialog.h 3c99e78 > KTp/Widgets/join-chat-room-dialog.cpp 4c2e9bf > > Diff: http://git.reviewboard.kde.org/r/111511/diff/ > > > Testing > ------- > > Still seems to be ok in ktp-contact-list > > > Thanks, > > Sven Brauch > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
