----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111527/#review36013 -----------------------------------------------------------
Ship it! I don't actually feel qualified to review dvratils code, but I still put some comments and if they're nonsense you can explain to me why :) In general, good feature, I want it -- Ship it! :) KTp/Widgets/join-chat-room-dialog.cpp <http://git.reviewboard.kde.org/r/111527/#comment26651> I didn't test it but is this actually needed? Currently if you double-click the room, it already gets filled in... So, if the comment below is correct too, could this maybe be simplified to just connecting all three slots to just QDialog::accept(), after the other slots were connected? KTp/Widgets/join-chat-room-dialog.cpp <http://git.reviewboard.kde.org/r/111527/#comment26650> Can we use accept() instead, or does it do something different than this? - Sven Brauch On July 15, 2013, 4:17 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111527/ > ----------------------------------------------------------- > > (Updated July 15, 2013, 4:17 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > I can't be bothered to move the mouse cursor all the way to the OK button. > > > Diffs > ----- > > KTp/Widgets/join-chat-room-dialog.h c996e76 > KTp/Widgets/join-chat-room-dialog.cpp 5fee7fa > > Diff: http://git.reviewboard.kde.org/r/111527/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
