> On July 25, 2013, 5:20 p.m., David Edmundson wrote: > > CMakeLists.txt, line 28 > > <http://git.reviewboard.kde.org/r/111682/diff/1/?file=173266#file173266line28> > > > > We should expand on why we use it, not just what it is. > > > > I'd like the message to say something more like: > > "Qt Bindings for TelpathyLogger. This is used for showing chat history > > with a contact. It is HIGHLY recommended. > > > > If you are a distribution packager and you see this message go back and > > do it again properly".
Ok, will update everywhere. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111682/#review36491 ----------------------------------------------------------- On July 25, 2013, 4:43 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111682/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 4:43 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Given it's a temporary solution before we come up with some abstraction for > 0.8, I think #ifdefs are fine > > > Diffs > ----- > > CMakeLists.txt db298f2 > KTp/CMakeLists.txt 203ed99 > KTp/message-processor.h 42f8be6 > KTp/message-processor.cpp ea2699d > KTp/message.h 982b8cf > KTp/message.cpp fa9c608 > KTp/outgoing-message.cpp 055017e > > Diff: http://git.reviewboard.kde.org/r/111682/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
