> On Aug. 13, 2013, 12:20 a.m., David Edmundson wrote: > > Fine with me. > > It's a behaviour change so I'll wait a bit for anyone else to comment > > before I ship it. > > Thomas Pfeiffer wrote: > Fine with me as well. "Typing" is not important enough to indicate it in > a redundant and confusing way.
Fwiw, the first implementation was working correctly - only when the user in active tab was typing, the window title would change. This is broken now and should be fixed. If Thomas thinks fixing by complete removing is good, then ship it from me as well. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112043/#review37631 ----------------------------------------------------------- On Aug. 13, 2013, 12:16 a.m., Daniel Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112043/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 12:16 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > When a user is talking to multiple people, it is confusing to have 'Typing... > Bob', when it's actually Fred in another tab who is typing. > > The presence of the both the chat tab status-icon change combined with the > tab name text colour change is sufficient to denote activity and removes this > confusion which is exacerbated with the more chat tabs that you have open. > > > Diffs > ----- > > app/chat-window.cpp d829125 > app/chat-window.h 3a5b6ba > > Diff: http://git.reviewboard.kde.org/r/112043/diff/ > > > Testing > ------- > > Tabs still change icon and colour upon user typing/message received. > > > Thanks, > > Daniel Cohen > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
