> On Aug. 15, 2013, 12:12 p.m., David Edmundson wrote: > > presence/src/presence-applet.cpp, line 165 > > <http://git.reviewboard.kde.org/r/112097/diff/1/?file=179726#file179726line165> > > > > just m_presences.append(presence) will do? > > Siddhartha Sahu wrote: > appending will not sort the statuses by type?
Good point, this makes sense now. Could you add a comment in the code to explain that addPresence() inserts in order. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112097/#review37836 ----------------------------------------------------------- On Aug. 15, 2013, 12:05 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112097/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 12:05 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This patch adds stored custom status to the context menu in telepathy > presence plasmoid in systray. > > > This addresses bug 317550. > http://bugs.kde.org/show_bug.cgi?id=317550 > > > Diffs > ----- > > presence/src/presence-applet.h 95b3f18 > presence/src/presence-applet.cpp fe1452c > > Diff: http://git.reviewboard.kde.org/r/112097/diff/ > > > Testing > ------- > > I have compiled and installed telepathy-kde from master and have tested the > changes on my laptop. All different types of custom messages that I have set > previously are present as as menu option, and selecting one of them > successfully sets the corresponding status. > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
