----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112181/#review38263 -----------------------------------------------------------
presence-model.cpp <http://git.reviewboard.kde.org/r/112181/#comment28298> this probably needs a config.sync() somewhere. presence-model.cpp <http://git.reviewboard.kde.org/r/112181/#comment28297> This is a synchronous dbus call. These are almost always bad. We block the contact-list running until the kernel switches to plasma and plasma runs processes it then returns back. With heavy dbus traffic or plasma being rubbish it's very easy to lock up our app. In this particular case the return value is not very useful and not used. We can make this async and ignore the reply. - David Edmundson On Aug. 20, 2013, 8:45 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112181/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2013, 8:45 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add Dbus messaging when custom presence is added or removed. This updates the > context menu of presence applet > > > This addresses bug 317550. > http://bugs.kde.org/show_bug.cgi?id=317550 > > > Diffs > ----- > > dialogs/custom-presence-dialog.cpp 11aadb9 > presence-model.h dcb9ccc > presence-model.cpp 72bfc3d > > Diff: http://git.reviewboard.kde.org/r/112181/diff/ > > > Testing > ------- > > Done locally from master. Adding and removing presences changes context menu > successfully > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
