-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112189/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
Documentation to KTp::LogsImporter clearly states that when error() signal, the
import can still continue importing further logs, so quitting in onError() slot
is just stupid. The awkward part is that I've written both code.
This makes the previous review for KTp::LogsImporter unnecessary (it won't
crash because KCM won't delete the importer until it emits finished()), but the
code there is still broken, so let's fix it anyway.
This addresses bug 323821.
http://bugs.kde.org/show_bug.cgi?id=323821
Diffs
-----
src/kcm-telepathy-accounts.h 665152f
src/kcm-telepathy-accounts.cpp d17efae
Diff: http://git.reviewboard.kde.org/r/112189/diff/
Testing
-------
Thanks,
Dan Vrátil
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
