----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112354/#review38840 -----------------------------------------------------------
app/chat-window.cpp <http://git.reviewboard.kde.org/r/112354/#comment28687> That's a crash in group chats targetContact will be null. app/chat-window.cpp <http://git.reviewboard.kde.org/r/112354/#comment28688> and again. app/chat-window.cpp <http://git.reviewboard.kde.org/r/112354/#comment28689> const & app/fileShareRequest.h <http://git.reviewboard.kde.org/r/112354/#comment28694> I think this would be best in k-c-i actions.h app/fileShareRequest.h <http://git.reviewboard.kde.org/r/112354/#comment28692> I want these merging into TpQt the ensureStreamTube ensureStreamTubeRoom app/fileShareRequest.h <http://git.reviewboard.kde.org/r/112354/#comment28693> why have this then. In this situation we would create a room, and use that. - David Edmundson On Aug. 29, 2013, 10:28 a.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112354/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2013, 10:28 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > This adds a "Share document" action to the text-ui. > > The action is automatically enabled only if both contacts actually support > the service. Otherwise, a tooltip is shown giving a hint on what to do to > enable it. > > > Diffs > ----- > > app/chat-window.h 30981d0 > app/chat-window.cpp c698204 > app/chatwindow.rc 01c27c5 > app/fileShareRequest.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112354/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > both you and the contact support the service > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/29/possible.png > you or the target contact does not support the service > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/29/not-possible.png > > > Thanks, > > Sven Brauch > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
