----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111501/#review38920 -----------------------------------------------------------
This review has been submitted with commit 3a4d0558ac38a7f2667aab943153cd4336a730a5 by David Edmundson to branch master. - Commit Hook On July 14, 2013, 10:05 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111501/ > ----------------------------------------------------------- > > (Updated July 14, 2013, 10:05 a.m.) > > > Review request for Telepathy and Andrea Scarpino. > > > Description > ------- > > Fix LaTeX filter > > Instead of trying to put the images inline we put a reference and insert the > LaTeX images at the end. > > The "appended message parts" aren't affected by other filters. > > > Diffs > ----- > > filters/latex/latex-filter.cpp 4e9601f095c1a3790e719b1cbbd1f32ed75c0424 > > Diff: http://git.reviewboard.kde.org/r/111501/diff/ > > > Testing > ------- > > currently code renders as <img src=".... because we run before the escape > filter. > > If we run after we get bugs because we escape before the LaTeX can get the > original code. > > This fixes both of them, and makes it clearer for larger amounts of text, as > otherwise line heights get confusing. > > > File Attachments > ---------------- > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/formula.png > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
