----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112491/#review39322 -----------------------------------------------------------
Ship it! Nicely done. Minor pendantic comments below. KTp/Widgets/start-chat-dialog.cpp <http://git.reviewboard.kde.org/r/112491/#comment28990> No it isn't :) KTp/Widgets/start-chat-dialog.cpp <http://git.reviewboard.kde.org/r/112491/#comment28989> Not used? KTp/Widgets/start-chat-dialog.cpp <http://git.reviewboard.kde.org/r/112491/#comment28988> this can be made const. - David Edmundson On Sept. 3, 2013, 6:27 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112491/ > ----------------------------------------------------------- > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Add startChatDialog to start chat with contact ids. > > > Diffs > ----- > > KTp/Widgets/CMakeLists.txt f9bdc3398cf0c84b8abe7b06327f2fa7c12e2798 > KTp/Widgets/start-chat-dialog.h PRE-CREATION > KTp/Widgets/start-chat-dialog.cpp PRE-CREATION > KTp/Widgets/start-chat-dialog.ui PRE-CREATION > KTp/actions.h 7cd12ac7dae92cfef6fc0fbca4fe3add6489b9f6 > KTp/actions.cpp f410183b9250559658779873d75e6b8c3fc08e5c > > Diff: http://git.reviewboard.kde.org/r/112491/diff/ > > > Testing > ------- > > Builds, tested in contact-list > > > Thanks, > > Anant Kamath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
