> On Sept. 8, 2013, 11:01 a.m., Sven Brauch wrote: > > Sounds good as an intermediate solution, given that the room name is always > > guaranteed to contain '@' (which I'm not sure about). > > David Edmundson wrote: > This code is safe when there's no @ too. > indexOf returns -1, .left(-1) returns the whole string.
Right, I somehow had in mind it'd return an empty string. But then all is fine. - Sven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112588/#review39573 ----------------------------------------------------------- On Sept. 8, 2013, 10:56 a.m., Frank Meerkoetter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112588/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2013, 10:56 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > ktp-text-ui is currently using the full jid as title (instead of the real > room name) of chat-widgets. This is taking up a lot of screen-real-estate > ([email protected] vs. someroom). If i open ~3 chatrooms i > am forced to constantly screen through my tabs. > > This patch provides a workaround by stripping the host-part from the jid. A > real solution would be to extend QtTp to provide the Telepathy roomname > property. > > > Diffs > ----- > > lib/chat-widget.cpp 25602ba > > Diff: http://git.reviewboard.kde.org/r/112588/diff/ > > > Testing > ------- > > > Thanks, > > Frank Meerkoetter > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
