-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112658/#review39795
-----------------------------------------------------------
I think this could be quite simplified with just the code below in teh contact
delegate (it's the same as in the groups header):
if (option.state & QStyle::State_Open) {
style->drawPrimitive(QStyle::PE_IndicatorArrowDown, &expandSignOption,
painter);
} else {
style->drawPrimitive(QStyle::PE_IndicatorArrowRight, &expandSignOption,
painter);
}
- Martin Klapetek
On Sept. 10, 2013, 11:56 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112658/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2013, 11:56 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Draw branches for contacts in KPeople mode
>
> To me it's a lot easier to use and navigate and doesn't look too bad.
>
> Requires https://git.reviewboard.kde.org/r/112657/
>
> Fixes 2 of the release blocking bugs.
>
> (https://bugs.kde.org/show_bug.cgi?id=324602 and
> https://bugs.kde.org/show_bug.cgi?id=324300)
> These could be solved in other ways, for me this patch is mostly about fixing
> the problem of double clicking expanding (not reported).
>
>
> Diffs
> -----
>
> contact-delegate-compact.cpp 945def1565707691072fbcd62b70756ee4e3ee84
> contact-list-widget.cpp 7c4c9308940828a923d3c196af51c12314114257
> contact-list-widget_p.h 5baae8776702c9f0f8aa78584a04ef402dea1d61
>
> Diff: http://git.reviewboard.kde.org/r/112658/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png
> Just arrows, no lines.
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/arrows1_1.png
> Before
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/fb1.png
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
