----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112736/#review40058 -----------------------------------------------------------
logviewer/dates-view-delegate.cpp <http://git.reviewboard.kde.org/r/112736/#comment29648> Can this by KIconLoader::iconSize(KIconLoader::Small) that way it uses the user's icon settings. Needed for the show-offs with the ridiculously high DPI screens. logviewer/dates-view-delegate.cpp <http://git.reviewboard.kde.org/r/112736/#comment29647> Ideally this should still be qMax(smallestReadableFont + SPACING, ACCOUNT_ICON_SIZE) just in case some blind person has super huge fonts. logviewer/dates-view-delegate.cpp <http://git.reviewboard.kde.org/r/112736/#comment29649> FYI (for future) there's a QStyle::drawItemPixmap() that centre-aligns painting a pixmap in the middle of a given rectangle. It means you don't have to do all the height() - iconSize + spacing/2 - whatever yourself. - David Edmundson On Sept. 15, 2013, 11:28 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112736/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2013, 11:28 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Good idea David :-) > > > This addresses bug 324919. > http://bugs.kde.org/show_bug.cgi?id=324919 > > > Diffs > ----- > > logviewer/dates-view-delegate.cpp af7536c > logviewer/entity-view-delegate.cpp cbede65 > > Diff: http://git.reviewboard.kde.org/r/112736/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
