----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112688/#review40410 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Sept. 21, 2013, 4:25 p.m., Sven Brauch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112688/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2013, 4:25 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Use more sensbile icons for the toolbar. See screenshot. Main problems which > I wanted to address: > * The "merge contacts" icon looks like it adds a contact. > * The "show grouped" icon is the "edit-group" icon which makes no sense and > also looks weird > * The "show offline" icon is the "meeting-attending-tentative" which makes > a) no sense and b) looks like it's disabled all the time. > > > Diffs > ----- > > contact-list-widget.h 44fc8d5 > contact-list-widget.cpp 98207c2 > main-widget.h c5eac93 > main-widget.cpp 5f2557e > > Diff: http://git.reviewboard.kde.org/r/112688/diff/ > > > Testing > ------- > > Nothing breaks by changing icons, does it? > > > File Attachments > ---------------- > > Suggested new icons, with "split group" icon > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png > Suggested new icons, with "group contacts" icon > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png > new "show offline" icon > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/icons4.png > New icons, next iteration > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/newicons.png > "Show grouped" as radio buttons > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/groups.png > > > Thanks, > > Sven Brauch > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
