> On Sept. 21, 2013, 11:08 p.m., David Edmundson wrote: > > The bug you're linking to is marked as resolved so what are we fixing here? > > > > There are two things that I think are going to cause problems: > > - One of the motivations for using requestedPresence was otherwise you > > could select something from the drop down menu and nothing would happen. > > > > - If I run "mc-tool request /someAccount offline". I would be marked as > > all offline, which is obviously not right. > > I know per account presences is sort of broken regardless (I need someone > > to fix the KDED module) but I don't want to make it worse. > > > > > > Note: Whatever you change in the presence applet, the contact applet also > > MUST match. > > > > Xuetian Weng wrote: > I linked it here because I don't think it's the right way to do this, the > real situation for that bug is quite mixed (As far as I see "click on > presence applet set it to busy" is actually fixed by this: > https://git.reviewboard.kde.org/r/112705/ ), but anyway, using > requestedPresence as presence applet icon is not correct. For example: > requested presence might be online but there is no network so it's shown as > online in presence applet. > > But if we don't change that code in ktp-desktop-applet, we still have a > problem described in this bug: there are two account, one supports hidden > presence and the other doesn't, the global current presence will be busy with > current code, since busy has "higher" priority. While this patch make it if > the "current" presence is equal to the "global" requested presence, this > presence will have higher priority. > > So there are three situations: > 1 account, all with full presence support -> no problem > 2 accounts, one support hidden the other is not, set presence to hidden > -> global currentPresence: hidden (before this patch: busy) > 1 account, doesn't support hidden, select hidden -> global > currentPresence: busy (still show it as hidden doesn't make much sense here). > > * If I run "mc-tool request /someAccount offline". I would be marked as > all offline, which is obviously not right. > - If there is only one account, global currentPresence will be offline > before and after patch. > - If there are two accounts, and the other is online, the global current > presence will still be online since it doesn't change the global request > presence. > > Is your "contact applet" contact list? the contact list always used > current presence in the combobox, so current situation is it doesn't match > and I also want to make it match... if you mean the per contact applet in > ktp-desktop-applet, it's not user controlled presence so I think it has > nothing to do with this change.
>requested presence might be online but there is no network so it's shown as >online in presence applet. But with a big spinny circle on top. >* If I run "mc-tool request /someAccount offline"... You are right, as global requestedPresence still keeps the highest one. >Is your "contact applet" contact list? Yes. I thought it used requestedPresence, but apparently not. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112875/#review40435 ----------------------------------------------------------- On Sept. 21, 2013, 9:36 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112875/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2013, 9:36 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Description > ------- > > This is related to https://bugs.kde.org/show_bug.cgi?id=302508 > http://commits.kde.org/telepathy-contact-applet/3b7a541d1ef8634b336ba9bd64a70dc4cc7027c3 > > The presence in applet is quite inaccurate when using requestedPresence as > its icon, while the problem is, if one of account doesn't support part of > presence which presence should be current presence. > > IMHO a better solution is to let currentPresence to be the one same as global > requested presence. So no matter in what case, the presence applet can show a > presence which an account actually is. > > If this passes the review I'd like to revert > http://commits.kde.org/telepathy-contact-applet/3b7a541d1ef8634b336ba9bd64a70dc4cc7027c3 > . > > > This addresses bug 302508. > http://bugs.kde.org/show_bug.cgi?id=302508 > > > Diffs > ----- > > KTp/global-presence.cpp 8e88be9 > > Diff: http://git.reviewboard.kde.org/r/112875/diff/ > > > Testing > ------- > > installed sault as the report, set to invisible, currentPresence is busy (I > have another gmail account supports hidden). > > > Thanks, > > Xuetian Weng > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
