----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113126/#review41303 -----------------------------------------------------------
Ship it! Based on my limited knowledge about proxy models, this looks correct. - Sven Brauch On Oct. 6, 2013, 12:30 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113126/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2013, 12:30 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Fix crash caused by TextChannelWatcherProxyModel > > void KTp::TextChannelWatcherProxyModel::onChannelMessagesChanged() > void KTp::TextChannelWatcherProxyModel::onChannelInvalidated() > emit dataChanged() using indexes from the wrong model. > > Because it's an QIdentityProxyModel it never causes any harm, > but it's still "wrong" so Qt asserts break in the grouping model. > > BUG: 325679 > > > Diffs > ----- > > KTp/Models/text-channel-watcher-proxy-model.cpp ea863fd > > Diff: http://git.reviewboard.kde.org/r/113126/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
