> On Oct. 6, 2013, 6:43 p.m., David Edmundson wrote: > > Needs update to notifyrc file and testing. > > > > There are now 8 different entries to the notification configuration (from > > 3) for receiving messages these all need to be added. > > IMHO this is maybe a bit too fine grained control, but as long as the > > defaults are OK I don't care. > > > > Note changes to notifyrc file will be an i18n change so this will be for 0.8 > > > > Thomas Pfeiffer wrote: > I think this may indeed be a little too fine-grained. Looking at thew > current set of notification types made me realise that they need to be > cleaned up anyway: Three different notification types each for Chatstyle or > Emoticonset Installation? Seriously??? I'd strongly recommend to look at the > notification types before 0.8 and reduce them a lot overall. > It may make sense to put the new ones created by this patch all in at > first so we really see what we're up against and can merge types where > possible.
The only notification types that I think might make sense to drop from this patch are for highlights in 1-to-1 chats. What do you think? - Leon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113134/#review41308 ----------------------------------------------------------- On Oct. 6, 2013, 4:56 p.m., Leon Handreke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113134/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2013, 4:56 p.m.) > > > Review request for Telepathy. > > > Bugs: 289348 > http://bugs.kde.org/show_bug.cgi?id=289348 > > > Repository: ktp-text-ui > > > Description > ------- > > Introduce new notification types for messages received in group chats > > As a side-effect, there is now also a separate event type for > highlights received in an active window. > > > Diffs > ----- > > lib/notify-filter.cpp a5c8ba091ade6ece89ec2d3bec2ef24b94cb417f > > Diff: http://git.reviewboard.kde.org/r/113134/diff/ > > > Testing > ------- > > > Thanks, > > Leon Handreke > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
