> On Oct. 12, 2013, 11:57 a.m., David Edmundson wrote: > > adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp, line 119 > > <http://git.reviewboard.kde.org/r/113214/diff/1/?file=200858#file200858line119> > > > > This line is quite important surely? > > > > Otherwise it won't do anything. > > Leon Handreke wrote: > The magic happens in ChatStyleInstaller (and EmoticonSetInstaller) - they > show a notification with an "OK" button that triggers this method (see the > showRequest() methods in both classes).
OK, I'll trust you :) Should I put this in 0.7? If so I need to drop the notifyrc change, and set the component data. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113214/#review41585 ----------------------------------------------------------- On Oct. 12, 2013, 11:39 a.m., Leon Handreke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113214/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2013, 11:39 a.m.) > > > Review request for Telepathy. > > > Bugs: 325903 > http://bugs.kde.org/show_bug.cgi?id=325903 > > > Repository: ktp-text-ui > > > Description > ------- > > Don't install the Adium extra automatically but show a notification to > confirm the installation (as was probably originally intended by the authors > of the code). > > Use a separate notifyrc file for adiumxtra-protocol-handler so that the > notification types used as the UI for adiumxtra-protocol-handler don't have > to show up in the notification configuration dialog for the ktelepathy > component anymore. > > Disable the KIO progress notification that results in a non-informative > "Copying [Finished]" notification for the temporary file being created. > > > Diffs > ----- > > adiumxtra-protocol-handler/CMakeLists.txt > 597fa753377b53f86503739dc670fa0caaf6af50 > adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp > b80e99a9d7e96be3ccf8be84e63522c07a70c296 > adiumxtra-protocol-handler/chat-style-installer.cpp > 9676c96a11263eef61bb14041ab002d11706f1d6 > adiumxtra-protocol-handler/emoticon-set-installer.cpp > a2011a33d34fcf757e69f790f8255fdd5492695e > adiumxtra-protocol-handler/ktp-adiumxtra-protocol-handler.notifyrc > PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113214/diff/ > > > Testing > ------- > > To test emoticon set installation: > $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler > 'adiumxtra://www.adiumxtras.com/download/4207') > To test message style installation: > $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler > 'adiumxtra://www.adiumxtras.com/download/7780') > > > Thanks, > > Leon Handreke > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
