----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113222/#review41629 -----------------------------------------------------------
KTp/Declarative/messages-model.cpp <http://git.reviewboard.kde.org/r/113222/#comment30433> This isn't ideal. We end up looping through the entire model every time there's an update. I'd like to keep some sort of QHash<QString /*messageToken*/ , QPersistentModelIndex > when we insert something then lookup from the hash table. KTp/Declarative/messages-model.cpp <http://git.reviewboard.kde.org/r/113222/#comment30434> watch your indentation. (though this could be just reviewboard showing it wrong) KTp/Declarative/messages-model.cpp <http://git.reviewboard.kde.org/r/113222/#comment30435> We're missing a crucial step. You update the data in the mode, but the view won't update. Every time you change the data in the model you have to call dataChanged(index,index); where index is the data you've changed so the views update. - David Edmundson On Oct. 12, 2013, 8:26 p.m., Leon Handreke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113222/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2013, 8:26 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Handle message delivery reports and update original message object with the > the new status and possibly an error message. > > Introduce a new internal MessagePrivate class to hold extra properties for > MessagesModel to avoid having to extend KTp::Message. > > > Diffs > ----- > > KTp/Declarative/messages-model.cpp 9cf1606555edc7ed9f36970a957a854caf3010a0 > KTp/Declarative/messages-model.h a0f15653c3644f26dc768fe7ac882b4ac3c91367 > > Diff: http://git.reviewboard.kde.org/r/113222/diff/ > > > Testing > ------- > > Only tested receiving a Tp::DeliveryStatusDelivered. Not sure how to test the > other cases. > > > Thanks, > > Leon Handreke > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
