----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113605/#review42964 -----------------------------------------------------------
This review has been submitted with commit d2aac601bb6b1f65e3ddf5fbd370a388eb3817dc by David Edmundson on behalf of Diane Trout to branch kde-telepathy-0.7. - Commit Hook On Nov. 4, 2013, 4:26 p.m., Diane Trout wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113605/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 4:26 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-send-file > > > Description > ------- > > Signature updates for change from Tp::ContactPtr to KTp::ContactPtr > > The signal signature for ContactGridWidget::selectionChanged changed in > ktp-common-internals and so the connection to the OK button in the UI never > got the message to enable itself. > > > Diffs > ----- > > mainwindow.h 397f6b9 > mainwindow.cpp 87fb0f7 > > Diff: http://git.reviewboard.kde.org/r/113605/diff/ > > > Testing > ------- > > 1) Launch dolphin > 2) right click on a file > 3) Actions->Send file to IM Contact. > 4) Select IM contact. > > Without patch, the OK button never lights up, with patch, OK button enables > and I can send a file. > > Unfortunately ktp contactlist still seems to have the send file UI element > grayed out. > > > Thanks, > > Diane Trout > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
