----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113803/#review43505 -----------------------------------------------------------
This review has been submitted with commit 5d2f4b9923e0fb1516050e295f7499411a8feea5 by David Edmundson on behalf of Alexandr Akulich to branch master. - Commit Hook On Nov. 12, 2013, 6:59 a.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113803/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2013, 6:59 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Get rid unnecessary include. > > > > Extract few string constants to static const string. > > > > Replace QString::contains() by startsWith() in service prefix matching. > > > > Rename newMediaPlayer() to watchPlayer() (inspired by unwatchAllPlayers()). > > > > Rename m_knownPlayers to m_watchedPlayers. > > > > Move few public slots to private slots or methods. > > > Diffs > ----- > > telepathy-mpris.h c223e94 > telepathy-mpris.cpp 93875fe > > Diff: http://git.reviewboard.kde.org/r/113803/diff/ > > > Testing > ------- > > Looks like it works as well, as before refactor. (Tested with amarok and > dragon player). > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
