----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113837/#review43598 -----------------------------------------------------------
KTp/Declarative/conversations-model.cpp <http://git.reviewboard.kde.org/r/113837/#comment31333> I don't understand why we do this. Can you explain it to me. KTp/Declarative/messages-model.h <http://git.reviewboard.kde.org/r/113837/#comment31334> This change is fine though :) - David Edmundson On Nov. 13, 2013, 2:40 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113837/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 2:40 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This acknowledges only in case the messages were loaded but were not shown. > Acknowledgement for message in current chat is done from QML itself. > > Can we move this to QML too? > > > Diffs > ----- > > KTp/Declarative/conversations-model.cpp 4e3489a > KTp/Declarative/messages-model.h 24d2cb8 > > Diff: http://git.reviewboard.kde.org/r/113837/diff/ > > > Testing > ------- > > Works > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
