----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113836/#review43599 -----------------------------------------------------------
KTp/Declarative/messages-model.h <http://git.reviewboard.kde.org/r/113836/#comment31335> Either we use d pointer style, or we use m_ variables. A mixture is bad. KTp/Declarative/messages-model.cpp <http://git.reviewboard.kde.org/r/113836/#comment31344> What do we use this for anyway? KTp/Logger/scrollback-manager.h <http://git.reviewboard.kde.org/r/113836/#comment31343> NO. KTp/Logger/scrollback-manager.cpp <http://git.reviewboard.kde.org/r/113836/#comment31342> You also go through a MessageProcessor in the model when you receive a message. This looks like you're doing it twice. (I would keep this one, remove the one in the MessagesModel) - David Edmundson On Nov. 13, 2013, 2:40 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113836/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 2:40 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This loads last 'n' messages into the message model when a chat is started. > > For now, KTp-text-ui's configuration is being used to determine 'n'. Where > will KTp-Active's configuration be stored? > > > Diffs > ----- > > KTp/Declarative/CMakeLists.txt 7208fd2 > KTp/Declarative/messages-model.h 24d2cb8 > KTp/Declarative/messages-model.cpp 601c418 > KTp/Logger/CMakeLists.txt 9bf6c68 > KTp/Logger/scrollback-manager.h PRE-CREATION > KTp/Logger/scrollback-manager.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113836/diff/ > > > Testing > ------- > > Works > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
