On Nov. 13, 2013, 3:41 p.m., Siddhartha Sahu wrote: > > I do remember something was wrong with the role names though. > > > > Who sets the role names? Maybe we can move setting the role names to this > > class only. > > Siddhartha Sahu wrote: > setSourceModel itself sets the rolenames. Thats why I included this call > to get the rolenames set properly. > > David Edmundson wrote: > I meant which model actually sets the role names to something. > > Siddhartha Sahu wrote: > Oh ok for Kpeople: KPeopleTranslationProxy, otherwise ContactsListModel
Where does KPeopleTranslationProxy set the role names? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113842/#review43596 ----------------------------------------------------------- On Nov. 13, 2013, 2:47 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113842/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 2:47 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This is working only sporadically. > > Is it because of setSourceModel being called from elsewhere too. > The model seems to contain all the role names even when the sorting fails (in > which case sorting seems random) > > > Diffs > ----- > > KTp/Models/contacts-model.cpp 0f69eb5 > > Diff: http://git.reviewboard.kde.org/r/113842/diff/ > > > Testing > ------- > > Not working perfectly yet. > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
