----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113814/ -----------------------------------------------------------
(Updated Nov. 25, 2013, 5:01 p.m.) Review request for Telepathy. Changes ------- Make reloadConfig() be pure virtual. Repository: ktp-kded-module Description ------- Small refactor of Telepathy KDED Module Plugins. TelepathyKDEDModulePlugin: Added virtual public slot reloadConfig(). AutoAway: Refactor readConfig() method to reloadConfig() slot. AutoAway: Get rid onSettingsChanged(). ScreenSaverAway: Refactor readConfig() method to reloadConfig() slot. ScreenSaverAway: Get rid onSettingsChanged(). TelepathyMPRIS: Rename onSettingsChanged() to reloadConfig(). Module: Connect settingsChanged() to reloadConfig() plugins slot. Get rid some useless includes. Diffs (updated) ----- autoaway.h 9496047 autoaway.cpp ec2afb6 contactnotify.h e3a5bb6 screensaveraway.h 9332953 screensaveraway.cpp 14f2092 telepathy-kded-module-plugin.h ac960e2 telepathy-module.cpp 19604bb telepathy-mpris.h f9469f1 telepathy-mpris.cpp a014b51 Diff: http://git.reviewboard.kde.org/r/113814/diff/ Testing ------- Compilation and plugin settings re-applying works fine. Thanks, Alexandr Akulich
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
