----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114106/#review44421 -----------------------------------------------------------
This review has been submitted with commit cc5ec6c7dfa5aeb64920d8ed827f1fabaa3149dc by David Edmundson on behalf of Alexandr Akulich to branch master. - Commit Hook On Nov. 25, 2013, 1:32 p.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114106/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2013, 1:32 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > KTp/Contact: Get rid few condition double-checks. > > There is may be small performance issue: we query both contact and self > capabilities, while if any of two ret false, another query is needless. > (I talk about code like such one:) > bool contactCanHandleFiles = capabilities().fileTransfers(); > bool selfCanHandleFiles = > manager()->connection()->selfContact()->capabilities().fileTransfers(); > return contactCanHandleFiles && selfCanHandleFiles; > > I didn't change it and hope for smart compiler. > > > Diffs > ----- > > KTp/contact.cpp 64dd49b > > Diff: http://git.reviewboard.kde.org/r/114106/diff/ > > > Testing > ------- > > Tested in different states. Capabilities of contacts are same as before this > change. There is no crashes or so. > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
