> On Nov. 28, 2013, 3:24 p.m., Martin Klapetek wrote: > > contact/src/contact-wrapper.cpp, line 287 > > <http://git.reviewboard.kde.org/r/114137/diff/2/?file=220146#file220146line287> > > > > I think this is supposed to be ::qObjectCast
I just look around and find it in ktp-contact-runner/src/contactrunner.cpp:266. Should I create review-request for this ^ place as well? It seems like may be I soon will have commit access, so is it better to fix it without RR? (I know well, that RR is natural thing for development process and ask only about this case) - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114137/#review44658 ----------------------------------------------------------- On Nov. 26, 2013, 6:03 p.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114137/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 6:03 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-desktop-applets > > > Description > ------- > > Port ContactWrapper capability getters from deprecated methods in > Tp::CapabilitiesBase to proper ones in KTp::Contact. > Next portion is to use KTp::Contact::avatarPixmap(), but it's delayed until > contacts and avatars cache be implemented. > > > Diffs > ----- > > contact/src/contact-wrapper.h 778a7a0 > contact/src/contact-wrapper.cpp b516960 > > Diff: http://git.reviewboard.kde.org/r/114137/diff/ > > > Testing > ------- > > Capability getters works as expected. > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
