> On Dec. 16, 2013, 11:35 a.m., David Edmundson wrote: > > Code is fine. > > > > In terms of UI. I don't think it's very clear what this option does. It's > > obvious if you know about the tab completion, but that's not a very > > apparent feature. > > > > Thoughts? > > Martin Klapetek wrote: > > Thoughts? > > Each UI-related changes should have a screenshot :) > > Leon, can you please attach one?
Yes, screenshot(s) please, then I'll review from the usability side as well ;) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114444/#review45768 ----------------------------------------------------------- On Dec. 14, 2013, 8:05 p.m., Leon Handreke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114444/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2013, 8:05 p.m.) > > > Review request for Telepathy. > > > Bugs: 326756 > http://bugs.kde.org/show_bug.cgi?id=326756 > > > Repository: ktp-text-ui > > > Description > ------- > > Make nick completion style configurable > > > Diffs > ----- > > config/behavior-config.h fcbdd7f678a8d975751c44afbdcda61771a59f8b > config/behavior-config.cpp 9f863dca930f1b39587fc63207d1c92d096a6559 > config/behavior-config.ui 200f6ee4023e11e9101dd10774d8095fab2e0120 > lib/chat-text-edit.cpp 4e0f0305b7ae18062f695eb26ee681a0c64aaf26 > lib/text-chat-config.h 603c00615d8bd51249ebff4e14fa5b44a2e5af0a > lib/text-chat-config.cpp 7425d5ea03b67022db813c2fffcdcb51c572e759 > > Diff: http://git.reviewboard.kde.org/r/114444/diff/ > > > Testing > ------- > > Clicked around in the UI, verified that all options work. > > > Thanks, > > Leon Handreke > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
