----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114577/#review45973 -----------------------------------------------------------
Ship it! src/basepersonsdatasource.cpp <http://git.reviewboard.kde.org/r/114577/#comment32808> Having two namespace declarations is useless, let's extend the namespace KPeople { .. } to the whole file src/basepersonsdatasource.cpp <http://git.reviewboard.kde.org/r/114577/#comment32807> struct has always its members public by default, so I'd suggest to either make it class { public: ... or just remove the public in here..no use for it. Sorry to make your work more boring ;) - Martin Klapetek On Dec. 20, 2013, 9:59 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114577/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 9:59 p.m.) > > > Review request for Telepathy. > > > Repository: libkpeople > > > Description > ------- > > D Pointer ContactMonitor and add KPeople namespace > > > D pointer BasePersonsDataSource > > > Diffs > ----- > > src/basepersonsdatasource.h 12f698e > src/basepersonsdatasource.cpp c416b3b > src/contactmonitor.h b921d92 > src/contactmonitor.cpp e20f491 > src/defaultcontactmonitor_p.h 797ac8a > src/plugins/akonadi/akonadidatasource.h ef5c602 > src/plugins/akonadi/akonadidatasource.cpp b640d00 > > Diff: http://git.reviewboard.kde.org/r/114577/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
