----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114559/#review45975 -----------------------------------------------------------
Ship it! I like it. As for .desktop property vs. virtual method - I think the latter is better as you can simply query sycocoa once, load all plugins and then just check against the id --> less kservice queries --> less disk access (though I'd assume that sycococoa is cached in memory too). - Martin Klapetek On Dec. 20, 2013, 1:27 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114559/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 1:27 a.m.) > > > Review request for Telepathy. > > > Repository: libkpeople > > > Description > ------- > > Only try loading data from the relevant data source > > i.e only query akonadi for contacts starting with akonadi:// > > > Thoughts: > - should this be a pure virtual method in the data source or a property in > the .desktop file? > > - the parsing of the IDs to get the sourceId from the url-looking string is > a bit rubbish, in a future patch I'll tidy this up with an ID class that > doesn't have this horrible string parsing. > > > Note this is an ABI break. > > > Diffs > ----- > > src/basepersonsdatasource.h 12f698e > src/persondata.cpp 277fa6b > src/personpluginmanager.h adc7b9d > src/personpluginmanager.cpp e433bb5 > src/plugins/akonadi/akonadidatasource.h ef5c602 > src/plugins/akonadi/akonadidatasource.cpp b640d00 > > Diff: http://git.reviewboard.kde.org/r/114559/diff/ > > > Testing > ------- > > Opened PersonViewer > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
