----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114643/#review46190 -----------------------------------------------------------
KTp/contact.cpp <https://git.reviewboard.kde.org/r/114643/#comment32988> Shouldn't you call manager->connection()->property("accountUID") every time from here? Otherwise this value will not get updated, when the value of the property changes in KTp::Account::onConnectionChanged(). Alternatively, you could listen to a signal in KTp::Contact and update the cached string. - Dan Vrátil On Dec. 24, 2013, 1:01 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114643/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2013, 1:01 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Set accountUniqueIdentifier on contacts > > Tp::Connection has no method to get the holding Tp::AccountPtr > > This makes it difficult to work out which account a contact belongs to. > This can't be fixed in TpQt in 0.9.x > > Instead create a KTp::Account which sets a property on connection > whenever the connection chanages. > > This is exposed from KTp::Contact > > > Diffs > ----- > > KTp/CMakeLists.txt 29ee1ab > KTp/account-factory.cpp PRE-CREATION > KTp/account-factory_p.h PRE-CREATION > KTp/contact.h f33a762 > KTp/contact.cpp 52a4f58 > KTp/core.cpp a221e68 > > Diff: https://git.reviewboard.kde.org/r/114643/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
