----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114718/ -----------------------------------------------------------
(Updated Dec. 29, 2013, 1:10 p.m.) Status ------ This change has been marked as submitted. Review request for Telepathy. Repository: ktp-common-internals Description ------- Remove ConversationTarget, put as title/avatar/presenceIcon into Conversation Diffs ----- KTp/Declarative/CMakeLists.txt 5517c31d511e04a0d695290d5044cf16bc958478 KTp/Declarative/conversation-target.h e620cdc75193e78f31e5d6a8cefb3d8b2a87b6cd KTp/Declarative/conversation-target.cpp 4e8af19397ec77fecf1a876d7378119204f02932 KTp/Declarative/conversation.h 38b313e700244173e8988e1e65cf48f82e04288b KTp/Declarative/conversation.cpp a3644fd6a2726a760ec4dfc3682cd3e93134f00b KTp/Declarative/conversations-model.cpp 4e3489adc07bc8d724a5456ee371bac32ea4add3 KTp/Declarative/pinned-contacts-model.cpp ccb5f2d251fb4c4bd7625d9c1ac527f4d1bc64b1 KTp/Declarative/qml-plugins.cpp 88e08bffc75809b3863ac0915c0ef53539c0810f Diff: https://git.reviewboard.kde.org/r/114718/diff/ Testing ------- Tested plasmoid, still works fine. Flipped the if in the Conversation constructor to make the Conversation think that it's a group chat, plasmoid still works (but doesn't show proper name, avatar and presence) and crashes when trying to pin contacts (the "star" button). Thanks, Leon Handreke
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
