----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115060/#review47835 -----------------------------------------------------------
contact-cache.cpp <https://git.reviewboard.kde.org/r/115060/#comment33891> It needs a CREATE TABLE call! and an index on the first two columns CREATE TABLE contacts (accountID VARCHAR NOT NULL, contactID VARCHAR NOT NULL, alias VARCHAR, avatarToken VARCHAR); contact-cache.cpp <https://git.reviewboard.kde.org/r/115060/#comment33892> We don't want to save contacts from local-xmpp. We need to filter them out. (kpeople should add/list them though) contact-cache.cpp <https://git.reviewboard.kde.org/r/115060/#comment33890> Long term we need groups too. - David Edmundson On Jan. 16, 2014, 8:48 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115060/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 8:48 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Save all persistent information on a contact to a database > > In KPeople we need the name + avatar of a person even when the > user is offline. The only approach is to have a small cache. > > This is apparently being merged into Telepathy at some point, > so we maybe remove this in future > > ---- > > Won't merge till we make the relevant change in the kpeople plugin too. > > > Diffs > ----- > > CMakeLists.txt a31245b > contact-cache.h PRE-CREATION > contact-cache.cpp PRE-CREATION > contactnotify.cpp 314d48a > telepathy-module.cpp a754283 > > Diff: https://git.reviewboard.kde.org/r/115060/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
