> On Jan. 24, 2014, 10:18 a.m., David Edmundson wrote: > > telepathy-mpris.cpp, line 264 > > <https://git.reviewboard.kde.org/r/115282/diff/1/?file=235593#file235593line264> > > > > I think this will cause problems. > > > > If you set yourself to Invisible and have a local-xmpp account which > > doesn't support invisible. When you listen to a track it will now move all > > your accounts "Away". > > > > Could you explain the problem we're trying to solve? > > James Smith wrote: > #114569 exposed an issue where the status will noticeably flicker in > ktp-plasma-applet when the status is set by the AutoAway plugin (from > Available state) and subsequent track changes in MPRIS2 change the status > without updating the away message, which is set in AutoAway and takes > precedence. The status will quickly switch back to Away from Available, > returning the Away status message instead of the MPRIS2 status message (and > associated Available state). > > So, don't even bother updating the MPRIS2 status and message. > > David Edmundson wrote: > Why does it go back to available before it goes to whatever MPRIS is set > to? > > James Smith wrote: > No, I don't think so. Because we're requesting what the presence is RIGHT > NOW, removing the current status message and pasting a new one in and relying > on the plugin priority to show a change in persistent status or not, the MC > plugins shouldn't receive a status change and instead should remain at what > the Ktp plugin allowed or explicitly (not persistently) set. The away KTp > plugin, being higher priority, won't allow the mpris2 KTp plugin to maintain > a changed status or changed status message. > > requestedPresence() should (will) return only what the global presence > was requested to be set at, not what currentPresence() reported the global > presence to actually be (plugins are taken into account by > requestedPresence()). > > The jump to global Available was caused by requestedPresence() reporting > the user-set presence, not the plugin-priority forced Away presence. The > mpris2 status message was ignored (properly) by the plugin ordering; however > the status flickered while mpris2 KTp plugin set the requested user presence, > changed the status message, and then returned (only to have the Away KTp > plugin re-take control over global status based on its timer, which caused a > reset to away hopefully before anybody noticed what happened by KTp mpris2.) > > I don't know if anyone would need mpris2 status messages while the > machine is autoway or on screensaver away? Probably bad netiquette.
>The jump to global Available was caused by requestedPresence() reporting the >user-set presence, not the plugin-priority forced Away presence. The mpris2 >status message was ignored (properly) by the plugin ordering; Why would it be ignored? - user is playing music - mpris plugin activates - presence is [online - "Some Song"] - user goes away - autoaway plugin activates - presence is [away - "I am not here right now"] - user comes - auto away plugin deactivates - presence gets set to that of the mpris plugin [online - "Some song"] I can imagine a bug in which a track change whilst away sets you to [away - "Some song"] when you come back; but this patch won't fix that, and that's not this flickering you describe. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115282/#review48184 ----------------------------------------------------------- On Jan. 24, 2014, 3:43 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115282/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 3:43 a.m.) > > > Review request for Telepathy and Xuetian Weng. > > > Repository: ktp-kded-module > > > Description > ------- > > Fixes state flicker when away plugin is active and track changes in a media > player. > > > Diffs > ----- > > telepathy-mpris.cpp 1c7b98c > > Diff: https://git.reviewboard.kde.org/r/115282/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
