> On Jan. 27, 2014, 6:16 p.m., David Edmundson wrote: > > contact-cache.cpp, line 197 > > <https://git.reviewboard.kde.org/r/115328/diff/1/?file=240707#file240707line197> > > > > why have an if on the connect()?
I added in-code comment for this. - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115328/#review48369 ----------------------------------------------------------- On Feb. 4, 2014, 9:23 p.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115328/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 9:23 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Was: https://git.reviewboard.kde.org/r/115060/ > > Draft version. Not proposed to be merged as is. > > TODO: > * Fix code > * Add groups info > * Performance testing. > > > Diffs > ----- > > CMakeLists.txt a31245b > contact-cache.h PRE-CREATION > contact-cache.cpp PRE-CREATION > contactnotify.cpp 314d48a > telepathy-module.cpp a754283 > > Diff: https://git.reviewboard.kde.org/r/115328/diff/ > > > Testing > ------- > > Tested accounts contact refreshing in follow action: > 1 Does connect via Telepathy. > 2 Checked that contacts added to db (via sqlite db viewer). > 3 Disconnected in telepathy. > 4 Connect via another IM software. > 5 Removed few contacts. > 6 Does connect via Telepathy. > 7 Checked that there is only actual contacts in db (via sqlite db viewer). > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
