----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115618/#review49427 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Feb. 10, 2014, 10:19 a.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115618/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 10:19 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Manually constructed factories and managers replaced by KTp ones. > Such change let us to cleanup code and let freely use KTp methods without > dbus traffic duplication (which is occurs in last commit). > > As according things: > Reworked includes. > Fixed a lot of coding style issues. > ContactNotify: Removed "using namespace KTp" from header. > > > Diffs > ----- > > error-handler.cpp 2b84784 > screensaveraway.cpp 6c47cfb > telepathy-kded-module-plugin.cpp 43cb383 > telepathy-module.h ec08c6e > telepathy-module.cpp bf154c6 > telepathy-mpris.cpp 1c7b98c > autoaway.h ac42718 > autoaway.cpp 79f62f0 > autoconnect.h aeb4b54 > autoconnect.cpp b779426 > contact-request-handler.h 69d2a1e > contact-request-handler.cpp 1b13194 > contactnotify.h 4dc71e4 > contactnotify.cpp 9f001f4 > error-handler.h dd62822 > > Diff: https://git.reviewboard.kde.org/r/115618/diff/ > > > Testing > ------- > > Compiled successfully. Seems to work, but not tested a lot. > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
