> On Feb. 19, 2014, 1:20 p.m., David Edmundson wrote: > > KTp/contact-info-dialog.cpp, line 333 > > <https://git.reviewboard.kde.org/r/115844/diff/1/?file=244655#file244655line333> > > > > I'd rather not delete the widgets and re-add them if we can avoid it. > > > > Can we just change update the icon?
because the dialog is not dynamic (so icons can be generated only once), no deletion will ever happen...so i removed the delete part... > On Feb. 19, 2014, 1:20 p.m., David Edmundson wrote: > > KTp/contact-info-dialog.cpp, line 391 > > <https://git.reviewboard.kde.org/r/115844/diff/1/?file=244655#file244655line391> > > > > publish state and subscription state can be unknown for other reasons > > (like the CM not supporting it) > > > > Also some accounts don't support feature Roster (local-xmpp), which > > means this then explodes unfortunately. > > > > I think we need > > > > if (connection->features() does not contain FeatureRoster && > > connection->supportedFeatures does contain FeatureRoster) { > > connection->becomeReady(...) > > } > > i hope connection->missingFeatures() does that stuff...it is not documented at all, so i am not 100% sure, but it is the only possible method in the class... - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115844/#review50213 ----------------------------------------------------------- On Feb. 20, 2014, 10 p.m., Jan Stourac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115844/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 10 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > dialog does not show correct icon indicating publish/subscription state due > to missing roster feature of connection... > > > Diffs > ----- > > KTp/contact-info-dialog.h 2bf8a57 > KTp/contact-info-dialog.cpp 1e7087e > > Diff: https://git.reviewboard.kde.org/r/115844/diff/ > > > Testing > ------- > > > Thanks, > > Jan Stourac > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
