----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116560/#review51753 -----------------------------------------------------------
Couple more nitpicks, then it's perfect ;) tools/debugger/debug-message-view.h <https://git.reviewboard.kde.org/r/116560/#comment36819> Why is this a slot? It's not used as a slot, can be just a public method tools/debugger/main-window.cpp <https://git.reviewboard.kde.org/r/116560/#comment36824> This is not needed tools/debugger/main-window.cpp <https://git.reviewboard.kde.org/r/116560/#comment36820> You missed renaming the slot here ;) tools/debugger/main-window.cpp <https://git.reviewboard.kde.org/r/116560/#comment36823> Thinking about it again now, naming it "saveFileDialog" makes no sense, just name it "saveLogFile" like the other slot. tools/debugger/main-window.cpp <https://git.reviewboard.kde.org/r/116560/#comment36821> This goes on the same line tools/debugger/main-window.cpp <https://git.reviewboard.kde.org/r/116560/#comment36822> ...and this should have a space before "break;" ;) tools/debugger/main-window.ui <https://git.reviewboard.kde.org/r/116560/#comment36825> It's not a "log file", it's just a "log"...being saved into a "file" --> Saves the log into a file - Martin Klapetek On March 3, 2014, 11:41 a.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116560/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 11:41 a.m.) > > > Review request for Telepathy. > > > Bugs: 303564 > http://bugs.kde.org/show_bug.cgi?id=303564 > > > Repository: ktp-common-internals > > > Description > ------- > > Adds a button Save Log file to save the log in the currentTab of the > TabWidget. > > > Diffs > ----- > > tools/debugger/debug-message-view.h 49a4b2f > tools/debugger/debug-message-view.cpp c2ead13 > tools/debugger/main-window.h 3876767 > tools/debugger/main-window.cpp faf7c22 > tools/debugger/main-window.ui 0813149 > > Diff: https://git.reviewboard.kde.org/r/116560/diff/ > > > Testing > ------- > > Runs fine! > > > Thanks, > > mayank jha > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
