----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116601/#review52025 -----------------------------------------------------------
Ship it! Good stuff, thanks. One more issue is that the buttons themselves are still not RTL but good enough for now. global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/116601/#comment36964> Note that it's placing it to the left, not the right - Martin Klapetek On March 5, 2014, 9:39 a.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116601/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 9:39 a.m.) > > > Review request for Telepathy. > > > Bugs: 319885 > http://bugs.kde.org/show_bug.cgi?id=319885 > > > Repository: ktp-contact-list > > > Description > ------- > > As the values were hardcoded, so the changes were not reflected upon applying > layout. Had to give the value for right to left. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/116601/diff/ > > > Testing > ------- > > Tests fine! > > > Thanks, > > mayank jha > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
