----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116607/#review52026 -----------------------------------------------------------
global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/116607/#comment36965> This seems wrong, it should be Q_FOREACH (const Tp::AccountPtr &account, m_accountManager->allAccounts()) { global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/116607/#comment36966> This is also wrong, it was correct before global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/116607/#comment36967> Same here global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/116607/#comment36968> Remove this, it will be replaced by your another patch (would cause troubles when merging) - Martin Klapetek On March 5, 2014, 9:47 a.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116607/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 9:47 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-contact-list > > > Description > ------- > > Fixed the coding style according to astyle script. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/116607/diff/ > > > Testing > ------- > > > Thanks, > > mayank jha > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
