> On March 11, 2014, 2:48 p.m., David Edmundson wrote: > > Ship it if you want, but I think there's an easier way. > > > > IMHO it would be easier to use > > connection->becomeReady(Connection::FeatureConnection) because then we can > > combine it with the becomeReady(roster) loading that's also here and drop > > the number of async things we're watching. > > > > Or we can probably add FeatureConnection to the default factories. > > > >
Where I can add it? I have tried to change line 148 to "connection->becomeReady(Tp::Features() << Tp::Connection::FeatureRoster << Tp::Connection::FeatureConnected);", but it doesn't fix issue. - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116704/#review52620 ----------------------------------------------------------- On March 11, 2014, 2:43 p.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116704/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 2:43 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > This patch fixes (for me) caching on onlineness changes. > Without this patch caching happens only if accounts already online before > module execution, which is usually not true. (was stucked on > onAccountConnectionChanged) > > > Diffs > ----- > > contact-cache.h 8fa6fac > contact-cache.cpp 47fe0cd > > Diff: https://git.reviewboard.kde.org/r/116704/diff/ > > > Testing > ------- > > After patch caching work just as planned. > > > Thanks, > > Alexandr Akulich > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
