> On March 12, 2014, 4:04 p.m., David Edmundson wrote:
> > libqtf/CMakeLists.txt, line 12
> > <https://git.reviewboard.kde.org/r/116769/diff/1/?file=253546#file253546line12>
> >
> > What's the difference between
> >
> > ${TP_QT4_FARSTREAM_INCLUDE_DIRS}
> > and
> > ${TELEPATHY_QT4_FARSTREAM_INCLUDE_DIR}
> >
> > It looks like one of these must be redundant?
> >
A wee bit redundant, yes. TelepathyQt4FarstreamConfig.cmake (from telepathy-qt)
provides ${TELEPATHY_QT4_FARSTREAM_INCLUDE_DIR}, but it doesn't include enough
information about dependent library/header paths to help here. Fixing
TelepathyQt4FarstreamConfig.cmake could be improved to provide the same
information we're getting from the pkg_check_modules(TP_FARSTREAM REQUIRED
telepathy-farstream) call made in this patch, but that means relying on someone
else to get this fixed. Doing it here/now would be at least a stop-gap measure
in the meantime, and shouldn't hurt anything either.
- Rex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116769/#review52810
-----------------------------------------------------------
On March 12, 2014, 3:53 p.m., Rex Dieter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116769/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 3:53 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-call-ui
>
>
> Description
> -------
>
> Use TelepathyQt4Farstream pkg-config flags instead of telepathy-farstream.
> In a perfect world these match,
> but when/if one has to install telepathy-farstream-0.4 in parallel and/or in
> a different place than telepathy-qt, things go wrong.
>
> This is one small step in fixing
> BUG: 312450
>
>
> Diffs
> -----
>
> libqtf/CMakeLists.txt 38d234b
>
> Diff: https://git.reviewboard.kde.org/r/116769/diff/
>
>
> Testing
> -------
>
> Been using this to build ktp-call-ui packages in fedora for quite awhile, due
> to having to install telepathy-farstream-0.4 in parallel (and in a different
> header prefix) to newer gst1-based telepathy-farstream-0.6
>
>
> Thanks,
>
> Rex Dieter
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
