-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116706/#review53949
-----------------------------------------------------------
/home/david/projects/kde4/src/ktp-common-internals/kpeople/datasourceplugin/im-persons-data-source.cpp:124:33:
error: use of undeclared identifier 'contactGroups'
addressee.setCategories(contactGroups);
^
/home/david/projects/kde4/src/ktp-common-internals/kpeople/datasourceplugin/im-persons-data-source.cpp:117:48:
warning: comparison of integers of different signs: 'uint' (aka 'unsigned
int') and 'int' [-Wsign-compare]
if ((!convSuccess) || (groupId >= groupsList.count()))
~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/build.make:80:
recipe for target
'kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/im-persons-data-source.cpp.o'
failed
make[2]: ***
[kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/im-persons-data-source.cpp.o]
Error 1
CMakeFiles/Makefile2:224: recipe for target
'kpeople/datasourceplugin/CMakeFiles/im_persons_data_source_plugin.dir/all'
failed
- David Edmundson
On March 14, 2014, 10:56 a.m., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116706/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 10:56 a.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 331272
> http://bugs.kde.org/show_bug.cgi?id=331272
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Implemented groups cache support.
>
>
> Diffs
> -----
>
> kpeople/datasourceplugin/im-persons-data-source.cpp 94d8de1
>
> Diff: https://git.reviewboard.kde.org/r/116706/diff/
>
>
> Testing
> -------
>
> Works as expected, but ktp-kded-module patch needed.
>
>
> Thanks,
>
> Alexandr Akulich
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
