> On March 24, 2014, 8:02 p.m., David Edmundson wrote: > > Sorry for the delay. I was on vacation. > > > > Long term I think I want a visual cue inside the chat tab. Otherwise the > > behaviour might just seem erratic, also I'd like to have save/restore per > > contact when starting a chat with a known contact. > > > > The code itself seems pretty rock solid. Thanks. > > Thomas Pfeiffer wrote: > I agree that a visual indicator of the layot used per tab would be > important for those using this feature. On the other hand, though, it would > be useless visual noise for those - presumably the majority of users - who > don't switch the layout. Maybe it could be only shown if users actually have > several layouts active, or follow the visibility of the layout switcher in > the systray?
Maybe we could use the "keyboard_layout_widget" plugin to add to the chat tab or the chat window. But I am not sure when should we start adding this widget, do we make it as a configuration parameter in Chat Tab Behaviour settings ? On March 24, 2014, 8:02 p.m., Ahmed Ibrahim wrote: > > Do you have commit access? No, but it would be great if I could apply for a KDE developer account. - Ahmed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116774/#review52877 ----------------------------------------------------------- On March 25, 2014, 12:15 a.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116774/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 12:15 a.m.) > > > Review request for Telepathy. > > > Bugs: 308953 > http://bugs.kde.org/show_bug.cgi?id=308953 > > > Repository: ktp-text-ui > > > Description > ------- > > Used DBus interface to switch the keyboard layout and listen to the keyboard > layout change. Stored the language in each ChatTab instance and then restore > it back when the ChatWindow is activated and when switching between tabs. > > > Diffs > ----- > > app/chat-window.h 793ac55 > app/chat-window.cpp 2c2e12b > lib/chat-widget.h c1dbd41 > lib/chat-widget.cpp e7c7619 > > Diff: https://git.reviewboard.kde.org/r/116774/diff/ > > > Testing > ------- > > Opened multiple ChatTabs and changed language of each one of them. When > Switching between the tabs the language indicator is changed according to the > language that is stored in the ChatTab. > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
