> On March 24, 2014, 10:30 a.m., Martin Klapetek wrote: > > Thanks for the patch. Unfortunately I don't think this patch has a place in > > KTp. I can see many scenarios where people's laptops won't suspend > > unexpectedly, possibly burning down in their bags while running for the > > bus, resulting in angry (KDE) users. If you want to disable > > suspending/power management, there's already a checkbox for that in the > > battery plasmoid, which does precisely this. I don't want to have > > duplicated functionality around the system hidden in a user application > > that virtually all users would never think of being the cause of their > > broken suspend. Sorry. > > > > I hate to trash the code and work that went into it; it helps if you talk > > to us about your ideas first :)
Lid switch and manual power events override custom application suspend inhibition. It's also just as simple to make certain to set Ktp off-line or change the settings in order to not inhibit suspend while hovering in a certain presence, or, keep it completely disabled. The only usable purpose would be to avoid missing incoming calls while away from the machine. I also forget most times about the battery monitor suspend switch, and dislike having to reset it after disabling, so most of the time I return to a sleeping or turned off machine. Thanks! - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114574/#review53933 ----------------------------------------------------------- On March 23, 2014, 8:28 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114574/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 8:28 a.m.) > > > Review request for Telepathy and Àlex Fiestas. > > > Repository: ktp-kded-module > > > Description > ------- > > KeepAwake plugin inhibits suspend for certain IM states. Also adds > infrastructure for presence-responsive plugins. > > > Diffs > ----- > > CMakeLists.txt d08606b > config/telepathy-kded-config.cpp baaceff > config/telepathy-kded-config.h 0400626 > config/telepathy-kded-config.ui 18f06f3 > keepawake.h PRE-CREATION > keepawake.cpp PRE-CREATION > telepathy-module.h 2213cdf > telepathy-module.cpp 030a0d9 > > Diff: https://git.reviewboard.kde.org/r/114574/diff/ > > > Testing > ------- > > Compile, runtime. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
